Test Raphaël #5
Open
rjr-git1 wants to merge 1 commit into
Open
Conversation
rglepe
reviewed
May 1, 2019
rglepe
left a comment
rglepe
left a comment
Contributor
There was a problem hiding this comment.
Es un buen ejercicio. El código es bastante legible y las etiquetas son autoexplicativas. Te hago algunas apreciaciones:
el element div.center sobra. Puedes hacer lo mismo con figure. Los nombres de las clases o id's procura que reflejen el contenido no el formato.
el elemento footer dentro de main y antes de aside te está impidiendo darle el formato correcto al documento.
El desbordamiento (propiedad overflow) no está controlado en el contenedor.
Los estilos de los enlaces de la barra de navegación no funcionan porque los estás aplicando al contenedor y no directamente a los enlaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merci:)